deps: Revert np to v7.7.0 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed because:
We used to use CircleCI and I created circle-wait to ensure that only one build ran at a time. But we don't do that any more 🤷 I suppose we could have test/server.js retry and wait. |
icio
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
LGTM, but damn it, npm what are you playing at?
$ npm i np@7
added 82 packages, removed 111 packages, and changed 60 packages in 6s
$ git diff --numstat -- package-lock.json
2094 2827 package-lock.json
How are we supposed to do supply-chain management with that kind of default behaviour?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with preview mode in the newly-released v8: sindresorhus/np#705