Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SourceGenerators): NativeCtorsGenerator will execute after XamlCodeGenerator #8686

Conversation

workgroupengineering
Copy link
Contributor

GitHub Issue (If applicable): closes #8684

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@workgroupengineering workgroupengineering requested a review from a team May 4, 2022 15:18
@gitpod-io
Copy link

gitpod-io bot commented May 4, 2022

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@jeromelaban jeromelaban enabled auto-merge May 4, 2022 15:21
@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label May 5, 2022
@jeromelaban jeromelaban merged commit 0db0498 into unoplatform:master May 8, 2022
@workgroupengineering workgroupengineering deleted the fixes/SourceGeneration/NativeCtorsGenerator-decpendecy branch May 9, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeCtorsGenerator do not generate ctor
3 participants