Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FolderPicker): [Skia][WPF] Added support at SuggestedStartLocati… #8202

Conversation

workgroupengineering
Copy link
Contributor

…on and CommitButtonText

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

SuggestedStartLocation and CommitButtonText is ignored.

What is the new behavior?

Added support at SuggestedStartLocation and CommitButtonText.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@workgroupengineering workgroupengineering requested a review from a team February 28, 2022 17:44
@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2022

Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the Codacity suggestions

@workgroupengineering workgroupengineering force-pushed the features/Skia/WPF/FolderPicker branch from 27749d6 to bc4db1e Compare March 2, 2022 10:36
@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Mar 2, 2022
@mergify mergify bot merged commit 96e801f into unoplatform:master Mar 6, 2022
@workgroupengineering workgroupengineering deleted the features/Skia/WPF/FolderPicker branch March 7, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants