Doc: Navbar will hide when iframed and send its size to its parent #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alextrepa
changed the title
|
The build 39203 found UI Test snapshots differences: Details
|
2 tasks
alextrepa
force-pushed
the
dev/altre/resize-docfx
branch
from
fb8f717 to
de7c540
Compare
|
The build 39554 found UI Test snapshots differences: Details
|
carldebilly
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently we pull the menu from the uno platform website and rebuild it at the top of the page to use it as a navbar. This means that every changes to the menu in the uno platform website has to be made in the doc also. It also means that changes made in the CMS might break the menu in the doc page. This makes changes to the menu harder than it should be.
What is the new behavior?
The doc will now be added as an iframe. The changes introduced makes it possible for the parent to know what size the iframe should be ; this makes the iframe responsive. It also removes the navbar, it will now use the same one as the rest of the website. It checks if the content is iframed first because it's hard to synchronize these changes with the website. This way the current behavior can continue until the changes are introduced in the website.
PR Checklist
Please check if your PR fulfills the following requirements:
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)Validated PRScreenshots Compare Test Runresults.Other information
Internal Issue (If applicable):
https://dev.azure.com/nventive/UNO%20Marketing/_workitems/edit/236738