fix(xLoad): [Android] Fix invalid x:Load reentrancy issue #7111

jeromelaban · 2021-09-16T15:30:52Z

GitHub Issue (If applicable): closes #6998

PR Type

What kind of change does this PR introduce?

Bugfix

What is the new behavior?

x:Load with Visibility binding does not fail with android.

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

gitpod-io · 2021-09-16T15:30:55Z

nventive-devops · 2021-09-16T19:34:59Z

The build 33549 found UI Test snapshots differences: android-28-net6: 0, android-28-xamarin: 21, android-28-xamarin-Snap: 27, ios: 29, ios-Snap: 44, skia-gtk-screenshots: 34, wasm: 9, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 6, wasm-automated-net5.0-RuntimeTests: 0

Details

android-28-net6: 0 changed over 1
android-28-xamarin: 21 changed over 731
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_Dropdown_Background_ComboBox_open
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
- ComboBoxTests_Disabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Disabled
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- CommandTest_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TestManipulation_Result
- PopupWithOverlay_After
- PasswordBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Simple
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- WebView_NavigateToAnchor_navigate_to_anchor
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- When_Click_Outside_Dialog_Expect_No_Dismiss_AfterClicking
- When_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClicking
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
android-28-xamarin-Snap: 27 changed over 916
🚨🚨 Comparison Details (first 20) 🚨🚨
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- ContentControlTestsControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- Default_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Default_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSize
- Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- GridTestsControl_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- ImageBrushTestControl_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- NavigationView_MUXControlsTestApp_NavigationViewPage_MUXControlsTestApp_NavigationViewPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- ScrollViewer_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding
- SplitButton_MUX_Test_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
- Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
ios: 29 changed over 275
🚨🚨 Comparison Details (first 20) 🚨🚨
- TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners
- Change_Manipulation_Property_Before_property_change
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- NativeCommandBar_Size_thirdOrientation
- UIElement_ContextFlyout_opened
- UIElement_ContextFlyout_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout
- Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
- Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- Change_Manipulation_Property_After_property_change
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
ios-Snap: 44 changed over 907
🚨🚨 Comparison Details (first 20) 🚨🚨
- Border_AutoBorderStretchwithbottommargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithbottommargin
- Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- GridTestsControl_Grid_with_TextBlock_VerticalAlignment_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_TextBlock_VerticalAlignment
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
- MediaPlayerElement_Original_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Original
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
- ImageBrushTestControl_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Routed_Events_TappedAndReleaseEvents_UITests_Shared_Windows_UI_Xaml_Input_RoutedEvents_RoutedEvent_TappedAndRelease
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
- ListView_ListView_Expandable_Item_Large_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- NavigationView_MUXControlsTestApp_NavigationViewPage_MUXControlsTestApp_NavigationViewPage
- ScrollViewer_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Nested_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Nested
- ScrollViewer_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding
skia-gtk-screenshots: 34 changed over 957
🚨🚨 Comparison Details (first 20) 🚨🚨
- Gesture recognizer-Pointer Events test bench
- ListView-ListView_IsSelected
- Image-Image_Stretch_Algmnt_Inf_Horizontal
- NavigationView-HierarchicalNavigationViewMarkup
- NavigationView-NavigationViewCompactPaneLengthTestPage
- NavigationView-PaneLayoutTestPage
- NumberBox-MUX_Test
- ScrollViewer-ScrollViewer_SnapPoints
- Shapes-Offscreen_Shapes
- NavigationView-NavigationViewCustomThemeResourcesPage
- NavigationView-NavigationViewPage
- NavigationView-NavigationViewRS3Page
- Progress-WinUIProgressBarSimple
- SwipeControl-SwipeControlPage2
- TextBlockControl-TextBlockMultilineInStarStackPanel
- TextBlockControl-TextBlockSimpleContrainedHorizontalCenterWrap2
- TextBox-PasswordBox_Simple
- TextBox-TextBox_Foreground_Changing
- Transform-TextBox_With_RotateTransform
- WebView-WebView_NavigateToUri
wasm: 9 changed over 916
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
- UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Vertical
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
- UITests.Uno_Web.Http.CookieManagerTests
- UITests.Windows_UI_Xaml_Shapes.Offscreen_Shapes
- Uno.UI.Samples.UITests.Image.Image_Stretch
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
wasm-automated-net5.0-Benchmarks: 0 changed over 1
wasm-automated-net5.0-Default: 6 changed over 803
🚨🚨 Comparison Details (first 20) 🚨🚨
- Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
- Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1
- Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
wasm-automated-net5.0-RuntimeTests: 0 changed over 1

nventive-devops · 2021-09-17T01:49:01Z

The build 33580 found UI Test snapshots differences: android-28-net6: 0, android-28-xamarin: 15, android-28-xamarin-Snap: 25, ios: 19, ios-Snap: 72, skia-gtk-screenshots: 31, wasm: 16, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 5, wasm-automated-net5.0-RuntimeTests: 0

Details

android-28-net6: 0 changed over 1
android-28-xamarin: 15 changed over 731
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_Dropdown_Background_ComboBox_open
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- PopupWithOverlay_After
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- WebView_NavigateToAnchor_navigate_to_anchor
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- When_Click_Outside_Dialog_Expect_No_Dismiss_AfterClicking
- When_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClicking
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
- When_Testing_ComplexSetters_UITests_Shared_Windows_UI_Xaml_VisualStateTests_VisualState_ComplexSetters_Automated
android-28-xamarin-Snap: 25 changed over 917
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- CommandBar_Native_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Native
- Default_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
- Default_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- GridTestsControl_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- ListView_ListView_DataTemplateSelector_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_DataTemplateSelector
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- NavigationView_MUXControlsTestApp_NavigationViewPage_MUXControlsTestApp_NavigationViewPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
- Map_MapControl_Uno_UI_Samples_Content_UITests_MapControl_MapControl
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
ios: 19 changed over 275
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- DatePicker_Flyout_DatePicker_-_Flyout
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Initial_State
- ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Expanded_State
- ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
ios-Snap: 72 changed over 908
🚨🚨 Comparison Details (first 20) 🚨🚨
- Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
- Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateX
- Animations_DoubleAnimation_Cumulative_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_Cumulative
- Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
- Border_Border_Simple_No_Background_With_TextBox_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_TextBox
- Border_Uniform_Thickness_and_Small_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Small_Radius
- ButtonTestsControl_Button_IsEnabled_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_Automated
- CheckBox_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated
- ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
- ContentControlTestsControl_ContentControl_Inheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Inheritance
- ContentControlTestsControl_ContentControl_MultiLevelInheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_MultiLevelInheritance
- ContentControlTestsControl_ContentControl_WithPadding_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithPadding
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Flyout_Flyout_ToggleMenu_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_ToggleMenu
- GridTestsControl_Grid_with_TextBlock_VerticalAlignment_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_TextBlock_VerticalAlignment
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom
- ImageBrushTestControl_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- ImageBrushTestControl_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large
skia-gtk-screenshots: 31 changed over 958
🚨🚨 Comparison Details (first 20) 🚨🚨
- DragAndDrop-DragDrop_TestPage
- Image-Image_Stretch
- Image-Image_Stretch_Algmnt_Inf_Horizontal
- Image-Image_Stretch_Algmnt_Inf_Vertical
- ImageBrushTestControl-ImageBrushChangingCornerRadius
- Image-Image_Stretch_Alignment_Bigger
- Image-Image_Stretch_Alignment_Equal
- Image-Image_Stretch_Alignment_SizeOnControl
- Image-Image_Stretch_Alignment_Smaller
- Image-Image_Stretch_Alignment_Wider
- ImageBrushTestControl-ImageBrush_StreamSource
- NavigationView-NavigationViewCustomThemeResourcesPage
- NavigationView-NavigationViewMinimalPage
- NavigationView-NavigationViewPage
- NavigationView-NavigationViewRS3Page
- Primitives-LoopingSelector_Short
- Progress-WinUIDeterminateProgressRing
- ListView-ListView_IsSelected
- NavigationView-PaneLayoutTestPage
- NavigationView-NavigationViewSample
wasm: 16 changed over 917
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
- UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Vertical
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Uno_Web.Http.CookieManagerTests
- UITests.Windows_UI_Xaml_Shapes.Offscreen_Shapes
- Uno.UI.Samples.UITests.Image.Image_Margin
- Uno.UI.Samples.UITests.Image.Image_Stretch
- Uno.UI.Samples.Samples.Shared.Content.UITests.ImageBrushInList
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Taller
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Wider
- Uno.UI.Samples.UITests.ImageBrushTestControl.Ellipse
wasm-automated-net5.0-Benchmarks: 0 changed over 1
wasm-automated-net5.0-Default: 5 changed over 803
🚨🚨 Comparison Details (first 20) 🚨🚨
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
wasm-automated-net5.0-RuntimeTests: 0 changed over 1

MartinZikmund · 2021-09-17T10:23:12Z

Seems there is a build issue - Error WMC0011: Unknown member 'Visibility' on element 'When_xLoad_Visibility_While_Materializing_Content'

src/Uno.UI.RemoteControl.VS/Uno.UI.RemoteControl.VS.csproj

This scenario may happen when `x:Load` is used with a visibility binding causing a invalid invocation of the ViewGroup.RemoveViewAt Android API.

nventive-devops · 2021-09-17T14:16:39Z

The build 33618 found UI Test snapshots differences: android-28-net6: 0, android-28-xamarin: 16, android-28-xamarin-Snap: 27, ios: 11, ios-Snap: 48, skia-gtk-screenshots: 35, wasm: 17, wasm-automated-net5.0-Benchmarks: 0, wasm-automated-net5.0-Default: 2, wasm-automated-net5.0-RuntimeTests: 0

Details

android-28-net6: 0 changed over 1
android-28-xamarin: 16 changed over 732
🚨🚨 Comparison Details (first 20) 🚨🚨
- ComboBoxTests_Fullscreen_Popup_Generic_Opened
- ComboBoxTests_Fullscreen_Popup_Generic_Closed
- ComboBox_Dropdown_Background_ComboBox_open
- PopupWithOverlay_After
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Test_FocusState_Interactive_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusState
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- WebView_NavigateToAnchor_navigate_to_anchor
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- When_Click_Outside_Dialog_Expect_No_Dismiss_AfterClicking
- When_Click_Outside_Dialog_Expect_No_Dismiss_BeforeClicking
- When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer
- TimePicker_Header_UITests_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Header
android-28-xamarin-Snap: 27 changed over 917
🚨🚨 Comparison Details (first 20) 🚨🚨
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
- Default_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
- GridTestsControl_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- ImageBrushTestControl_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
- NavigationView_MUXControlsTestApp_HierarchicalNavigationViewMarkup_MUXControlsTestApp_HierarchicalNavigationViewMarkup
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- NavigationView_MUXControlsTestApp_NavigationViewPage_MUXControlsTestApp_NavigationViewPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Map_MapControl_Uno_UI_Samples_Content_UITests_MapControl_MapControl
- MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
- MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
- Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
ios: 11 changed over 275
🚨🚨 Comparison Details (first 20) 🚨🚨
- Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
- Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
- NativeCommandBar_Size_thirdOrientation
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
ios-Snap: 48 changed over 908
🚨🚨 Comparison Details (first 20) 🚨🚨
- Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateX
- Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
- Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
- Border_Border_Simple_No_Background_With_TextBox_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_TextBox
- ContentControlTestsControl_ContentControl_Inheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Inheritance
- ContentControlTestsControl_ContentControl_MultiLevelInheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_MultiLevelInheritance
- ContentControlTestsControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- ContentControlTestsControl_ContentControl_SetNull_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_SetNull
- ContentControlTestsControl_ContentControl_WithPadding_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithPadding
- ContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Background
- ContentPresenter_ContentPresenter_TextProperties_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_TextProperties
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- GridTestsControl_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- GridTestsControl_Grid_with_Stack_Panel_and_Trimming_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Stack_Panel_and_Trimming
- GridTestsControl_Grid_with_TextBlock_VerticalAlignment_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_TextBlock_VerticalAlignment
- GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
- GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom
- ImageBrushTestControl_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- ImageBrushTestControl_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- ImageBrushTestControl_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
skia-gtk-screenshots: 35 changed over 958
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image-Image_Stretch_Algmnt_Inf_Vertical
- Image-Image_Stretch_Alignment_Bigger
- Image-Image_Stretch_Alignment_SizeOnControl
- Image-Image_Stretch_Alignment_Smaller
- Image-Image_Stretch_Alignment_Taller
- Image-Image_Stretch_Alignment_Wider
- ListView-ListView_IsSelected
- NavigationView-NavigationViewCompactPaneLengthTestPage
- NavigationView-NavigationViewCustomThemeResourcesPage
- NavigationView-NavigationViewSample
- NavigationView-NavigationViewStretchPage
- NavigationView-NavigationViewTopNavPage
- NavigationView-PaneLayoutTestPage
- NumberBox-MUX_Test
- NumberBox-NumberBox_Header
- Page-Page_Automated
- Pointers-HitTest_Image
- Pointers-ScrollViewer_PointerMoved
- Popup-MessageDialog
- Primitives-LoopingSelector_Short
wasm: 17 changed over 917
🚨🚨 Comparison Details (first 20) 🚨🚨
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
- UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
- UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
- UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
- UITests.Microsoft_UI_Xaml_Controls.ImageIconTests.ImageIconPage
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
- UITests.Windows_UI_Xaml.DragAndDrop.DragDrop_TestPage
- UITests.Windows_UI_Xaml_Shapes.Offscreen_Shapes
- Uno.UI.Samples.UITests.Image.Image_Margin
- Uno.UI.Samples.UITests.Image.Image_Stretch
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Bigger
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Equal
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Smaller
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Taller
- Uno.UI.Samples.UITests.Image.Image_Stretch_Alignment_Wider
- Uno.UI.Samples.UITests.ImageBrushTestControl.Ellipse
wasm-automated-net5.0-Benchmarks: 0 changed over 1
wasm-automated-net5.0-Default: 2 changed over 803
🚨🚨 Comparison Details (first 20) 🚨🚨
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
wasm-automated-net5.0-RuntimeTests: 0 changed over 1

jeromelaban requested a review from a team September 16, 2021 15:30

jeromelaban force-pushed the dev/jela/xload-race branch from 715eda1 to 6ea53d1 Compare September 16, 2021 17:11

MartinZikmund approved these changes Sep 16, 2021

View reviewed changes

ajpinedam approved these changes Sep 16, 2021

View reviewed changes

jeromelaban force-pushed the dev/jela/xload-race branch from 6ea53d1 to 9301c3a Compare September 16, 2021 20:24

jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Sep 16, 2021

jeromelaban force-pushed the dev/jela/xload-race branch from 9301c3a to 7c72ab4 Compare September 16, 2021 23:29

jeromelaban force-pushed the dev/jela/xload-race branch from 7c72ab4 to 8d58e7e Compare September 17, 2021 01:55

MartinZikmund reviewed Sep 17, 2021

View reviewed changes

src/Uno.UI.RemoteControl.VS/Uno.UI.RemoteControl.VS.csproj Show resolved Hide resolved

fix(2022): Fix remote control build under VS2022

1a1b091

jeromelaban force-pushed the dev/jela/xload-race branch from 8d58e7e to 69f5561 Compare September 17, 2021 11:37

fix(xLoad): [Android] Fix invalid x:Load reentrancy issue

9784464

This scenario may happen when `x:Load` is used with a visibility binding causing a invalid invocation of the ViewGroup.RemoveViewAt Android API.

jeromelaban force-pushed the dev/jela/xload-race branch from 69f5561 to 9784464 Compare September 17, 2021 12:20

jeromelaban merged commit 1b8b0a2 into master Sep 20, 2021

jeromelaban deleted the dev/jela/xload-race branch September 20, 2021 13:52

Youssef1313 mentioned this pull request Oct 22, 2021

ci: Bump to C# 10 #7378

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(xLoad): [Android] Fix invalid x:Load reentrancy issue #7111

fix(xLoad): [Android] Fix invalid x:Load reentrancy issue #7111

jeromelaban commented Sep 16, 2021

gitpod-io bot commented Sep 16, 2021

nventive-devops commented Sep 16, 2021

nventive-devops commented Sep 17, 2021

MartinZikmund commented Sep 17, 2021

nventive-devops commented Sep 17, 2021

fix(xLoad): [Android] Fix invalid x:Load reentrancy issue #7111

fix(xLoad): [Android] Fix invalid x:Load reentrancy issue #7111

Conversation

jeromelaban commented Sep 16, 2021

PR Type

What is the new behavior?

PR Checklist

Other information

gitpod-io bot commented Sep 16, 2021

nventive-devops commented Sep 16, 2021

nventive-devops commented Sep 17, 2021

MartinZikmund commented Sep 17, 2021

nventive-devops commented Sep 17, 2021