Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes TextBox cursor color for Android 29+ #6941

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

Hudney
Copy link
Contributor

@Hudney Hudney commented Sep 2, 2021

GitHub Issue: closes #6240

PR Type

  • Fix

What is the current behavior?

Error changing cursor color in API 29+

What is the new behavior?

Fix cursor color change for Android 29+

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Before

Android 10

After

Android 11

@Hudney Hudney requested a review from a team September 2, 2021 17:01
@gitpod-io
Copy link

gitpod-io bot commented Sep 2, 2021

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I validated the change on an Android 30, and it seems to be working fine.

@ajpinedam
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeromelaban jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Sep 8, 2021
@mergify mergify bot merged commit 491302a into unoplatform:master Sep 8, 2021
@welcome
Copy link

welcome bot commented Sep 8, 2021

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Migrate off mCursorDrawableRes (setting cursor color on TextView) as throws error in api 29 and higher
3 participants