fix: Apply icon color correctly inside native AppBarButton

[Youssef1313]

GitHub Issue (If applicable): #6732 (Android only is fixed)

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

Icons inside AppBarButton don't get their color correctly.

What is the new behavior?

Correctly set their color.

PR Checklist

Please check if your PR fulfills the following requirements:

• Docs have been added/updated which fit documentation template (for bug fixes / features)
• Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• Validated PR Screenshots Compare Test Run results.
• Contains NO breaking changes
• Associated with an issue (GitHub or internal) and uses the automatic close keywords.
• Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

[gitpod-io]

[jeromelaban]

Don't mind the build errors, it looks like a nuget fluke.

It's important to create a ui test for that one, though. You can create a solid colored square, and poke at the pixels to determine if the change was done properly.

[jeromelaban]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Youssef1313]

@MartinZikmund Can you re-run the failing tests? (I don't have permissions to do so)

[jeromelaban]

The UI test did not work it seems:

For wasm it's expected as it's a native command bar test, which may not apply, but for iOS, the test should be working though.

https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1563684&_a=resultSummary&resultId=100000

Looking at the screenshots, the result does not seem to be correct but this is expected as the XAML is supposed to be running on Android only:

uno/src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/CommandBar/CommandBar_Native_With_Content.xaml

Line 53 in cf14a75

<android:CommandBar x:Name="MyCommandBar"

You'll certainly need to create a new sample XAML file to test your scenario all available platforms.

[Youssef1313]

@jeromelaban This doesn't seem to be working on iOS. I don't have an iPhone or a Mac to try figuring out what's happening. Can we skip the test for iOS for now and open a new issue tracking that?

[jeromelaban]

You'll need to exclude this test for WebAssembly (the CommandBar is not set for this platform in the test). As for iOS, you can troubleshoot by looking at the screenshots there: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1564386&_a=resultSummary&resultId=100000

[Youssef1313]

Yeah I saw the screenshot in CI. For iOS, the icon doesn't seem to appear at all. Hard to investigate without a real device to debug. I reverted the iOS change temporarily to see if the icon will start appearing, after that let's see how we can move forward.

[Youssef1313]

@jeromelaban I skipped the test for iOS for now since I'm not sure what's going on (I suspect the test XAML code itself is problematic on iOS, since there is no icon at all).