Fix visual transition support

src/Uno.UI/FeatureConfiguration.cs

@@ -493,6 +493,16 @@ public static class UIElement
 #endif
 		}
 
+		public static class VisualState
+		{
+			/// <summary>
+			/// When this is set, the <see cref="Windows.UI.Xaml.VisualState.Setters"/> will be applied synchronously when changing state,
+			/// unlike UWP which waits the for the end of the <see cref="VisualTransition.Storyboard"/> (if any) to apply them.
+			/// </summary>
+			/// <remarks>This flag is for backward compatibility with old versions of uno and should not be turned on.</remarks>
+			public static bool ApplySettersBeforeTransition { get; set; } = false;
+		}
+
 		public static class WebView
 		{
 #if __ANDROID__

src/Uno.UI/UI/Xaml/Media/Animation/ObjectAnimationUsingKeyFrames.cs

@@ -251,9 +251,9 @@ private void Play()
 					_scheduledFrames.Add(
 						CoreDispatcher.Main.RunAsync(
 							CoreDispatcherPriority.Normal,
-							async () =>
+							async ct =>
 							{
-								await Task.Delay(dueTime);
+								await Task.Delay(dueTime, ct);
 								update();
 							}
 						)

src/Uno.UI/UI/Xaml/Media/Animation/Storyboard.cs

@@ -287,6 +287,7 @@ internal void TurnOverAnimationsTo(Storyboard storyboard)
 					((ITimeline)child).Stop();
 				}
 			}
+
 			State = TimelineState.Stopped;
 		}
 

src/Uno.UI/UI/Xaml/Media/Animation/Timeline.cs

@@ -24,7 +24,7 @@ public Timeline()
 			State = TimelineState.Stopped;
 		}
 
-		protected enum TimelineState
+		protected internal enum TimelineState
 		{
 			Active,
 			Filling,
@@ -46,7 +46,7 @@ protected string[] GetTraceProperties()
 		/// An internally-used property which is essentially equivalent to <see cref="Storyboard.GetCurrentState"/>, except that it 
 		/// distinguishes <see cref="TimelineState.Active"/> from <see cref="TimelineState.Paused"/>.
 		/// </summary>
-		protected TimelineState State { get; set; }
+		protected internal TimelineState State { get; set; }
 
 		public TimeSpan? BeginTime
 		{

src/Uno.UI/UI/Xaml/UIElement.Pointers.Managed.cs

@@ -8,6 +8,7 @@
 using System.Numerics;
 using System.Runtime.CompilerServices;
 using System.Text;
+using Windows.Devices.Input;
 using Microsoft.Extensions.Logging;
 using Uno.Disposables;
 using Uno.Extensions;
@@ -137,6 +138,12 @@ private void CoreWindow_PointerExited(CoreWindow sender, PointerEventArgs args)
 				var routedArgs = new PointerRoutedEventArgs(args, originalSource);
 
 				Raise(Leave, overBranchLeaf, routedArgs);
+				if (!args.CurrentPoint.IsInContact && args.CurrentPoint.Pointer.Type == PointerDeviceType.Touch)
+				{
+					// We release the captures on exit when pointer if not pressed
+					// Note: for a "Tap" with a finger the sequence is Up / Exited / Lost, so the lost cannot be raised on Up
+					ReleaseCaptures(routedArgs);
+				}
 			}
 
 			private void CoreWindow_PointerPressed(CoreWindow sender, PointerEventArgs args)
@@ -172,6 +179,7 @@ private void CoreWindow_PointerPressed(CoreWindow sender, PointerEventArgs args)
 			private void CoreWindow_PointerReleased(CoreWindow sender, PointerEventArgs args)
 			{
 				var (originalSource, _) = VisualTreeHelper.HitTest(args.CurrentPoint.Position);
+				var isOutOfWindow = originalSource is null;
 
 				// Even if impossible for the Release, we are fallbacking on the RootElement for safety
 				// This is how UWP behaves: when out of the bounds of the Window, the root element is use.
@@ -196,6 +204,12 @@ private void CoreWindow_PointerReleased(CoreWindow sender, PointerEventArgs args
 				var routedArgs = new PointerRoutedEventArgs(args, originalSource);
 
 				RaiseUsingCaptures(Released, originalSource, routedArgs);
+				if (isOutOfWindow || args.CurrentPoint.Pointer.Type != PointerDeviceType.Touch)
+				{
+					// We release the captures on up but only after the released event and processed the gesture
+					// Note: For a "Tap" with a finger the sequence is Up / Exited / Lost, so we let the Exit raise the capture lost
+					ReleaseCaptures(routedArgs);
+				}
 				ClearPressedState(routedArgs);
 			}
 
@@ -266,9 +280,21 @@ private void CoreWindow_PointerCancelled(CoreWindow sender, PointerEventArgs arg
 				var routedArgs = new PointerRoutedEventArgs(args, originalSource);
 
 				RaiseUsingCaptures(Cancelled, originalSource, routedArgs);
+				// Note: No ReleaseCaptures(routedArgs);, the cancel automatically raise it
 				ClearPressedState(routedArgs);
 			}
 
+			private void ReleaseCaptures(PointerRoutedEventArgs routedArgs)
+			{
+				if (PointerCapture.TryGet(routedArgs.Pointer, out var capture))
+				{
+					foreach (var target in capture.Targets)
+					{
+						target.Element.ReleasePointerCapture(capture.Pointer);
+					}
+				}
+			}
+
 			private void ClearPressedState(PointerRoutedEventArgs routedArgs)
 			{
 				if (_pressedElements.TryGetValue(routedArgs.Pointer, out var pressedLeaf))
@@ -285,7 +311,7 @@ private void ClearPressedState(PointerRoutedEventArgs routedArgs)
 				}
 			}
 
-#region Helpers
+			#region Helpers
 			private delegate void RaisePointerEventArgs(UIElement element, PointerRoutedEventArgs args, BubblingContext ctx);
 
 			private static readonly RaisePointerEventArgs Wheel = (elt, args, ctx) => elt.OnPointerWheel(args, ctx);
@@ -351,7 +377,7 @@ private static void RaiseUsingCaptures(RaisePointerEventArgs raise, UIElement or
 					raise(originalSource, routedArgs, BubblingContext.Bubble);
 				}
 			}
-#endregion
+			#endregion
 		}
 
 		// TODO Should be per CoreWindow
@@ -365,7 +391,7 @@ partial void InitializePointersPartial()
 			}
 		}
 
-#region HitTestVisibility
+		#region HitTestVisibility
 		internal void UpdateHitTest()
 		{
 			this.CoerceValue(HitTestVisibilityProperty);
@@ -434,7 +460,7 @@ internal void ClearHitTestVisibilityForRoot()
 			this.ClearValue(HitTestVisibilityProperty);
 		}
 
-#endregion
+		#endregion
 
 		partial void CapturePointerNative(Pointer pointer)
 			=> CoreWindow.GetForCurrentThread()!.SetPointerCapture();

src/Uno.UI/UI/Xaml/UIElement.Pointers.cs

@@ -857,7 +857,6 @@ private bool OnPointerUp(PointerRoutedEventArgs args, BubblingContext ctx = defa
 
 			handledInManaged |= SetPressed(args, false, muteEvent: ctx.IsLocalOnly || !isOverOrCaptured);
 
-
 			// Note: We process the UpEvent between Release and Exited as the gestures like "Tap"
 			//		 are fired between those events.
 			if (_gestures.IsValueCreated)
@@ -873,13 +872,15 @@ private bool OnPointerUp(PointerRoutedEventArgs args, BubblingContext ctx = defa
 				}
 			}
 
+#if !UNO_HAS_MANAGED_POINTERS // Captures release are handled a root level
 			// We release the captures on up but only after the released event and processed the gesture
 			// Note: For a "Tap" with a finger the sequence is Up / Exited / Lost, so we let the Exit raise the capture lost
 			// Note: If '!isOver', that means that 'IsCaptured == true' otherwise 'isOverOrCaptured' would have been false.
 			if (!isOver || args.Pointer.PointerDeviceType != PointerDeviceType.Touch)
 			{
 				handledInManaged |= SetNotCaptured(args);
 			}
+#endif
 
 			return handledInManaged;
 		}
@@ -898,12 +899,14 @@ private bool OnPointerExited(PointerRoutedEventArgs args, BubblingContext ctx =
 				global::Windows.UI.Xaml.Window.Current.DragDrop.ProcessMoved(args);
 			}
 
+#if !UNO_HAS_MANAGED_POINTERS // Captures release are handled a root level
 			// We release the captures on exit when pointer if not pressed
 			// Note: for a "Tap" with a finger the sequence is Up / Exited / Lost, so the lost cannot be raised on Up
 			if (!IsPressed(args.Pointer))
 			{
 				handledInManaged |= SetNotCaptured(args);
 			}
+#endif
 
 			return handledInManaged;
 		}
@@ -990,9 +993,9 @@ private bool RaisePointerEvent(RoutedEvent evt, PointerRoutedEventArgs args, Bub
 				_pendingRaisedEvent = (null, null, null);
 			}
 		}
-		#endregion
+#endregion
 
-		#region Pointer over state (Updated by the partial API OnNative***, should not be updated externaly)
+#region Pointer over state (Updated by the partial API OnNative***, should not be updated externaly)
 		/// <summary>
 		/// Indicates if a pointer (no matter the pointer) is currently over the element (i.e. OverState)
 		/// WARNING: This might not be maintained for all controls, cf. remarks.
@@ -1039,9 +1042,9 @@ private bool SetOver(PointerRoutedEventArgs args, bool isOver, bool muteEvent =
 				return RaisePointerEvent(PointerExitedEvent, args);
 			}
 		}
-		#endregion
+#endregion
 
-		#region Pointer pressed state (Updated by the partial API OnNative***, should not be updated externaly)
+#region Pointer pressed state (Updated by the partial API OnNative***, should not be updated externaly)
 		private readonly HashSet<uint> _pressedPointers = new HashSet<uint>();
 
 		/// <summary>
@@ -1113,9 +1116,9 @@ private bool SetPressed(PointerRoutedEventArgs args, bool isPressed, bool muteEv
 		}
 
 		private void ClearPressed() => _pressedPointers.Clear();
-		#endregion
+#endregion
 
-		#region Pointer capture state (Updated by the partial API OnNative***, should not be updated externaly)
+#region Pointer capture state (Updated by the partial API OnNative***, should not be updated externaly)
 		/*
 		 * About pointer capture
 		 *
@@ -1129,7 +1132,7 @@ private bool SetPressed(PointerRoutedEventArgs args, bool isPressed, bool muteEv
 
 		private List<Pointer> _localExplicitCaptures;
 
-		#region Capture public (and internal) API ==> This manages only Explicit captures
+#region Capture public (and internal) API ==> This manages only Explicit captures
 		public static DependencyProperty PointerCapturesProperty { get; } = DependencyProperty.Register(
 			"PointerCaptures",
 			typeof(IReadOnlyList<Pointer>),
@@ -1196,7 +1199,7 @@ public void ReleasePointerCaptures()
 
 			Release(PointerCaptureKind.Explicit);
 		}
-		#endregion
+#endregion
 
 		partial void CapturePointerNative(Pointer pointer);
 		partial void ReleasePointerNative(Pointer pointer);
@@ -1295,9 +1298,9 @@ private bool Release(PointerCapture capture, PointerCaptureKind kinds, PointerRo
 			relatedArgs.Handled = false;
 			return RaisePointerEvent(PointerCaptureLostEvent, relatedArgs);
 		}
-		#endregion
+#endregion
 
-		#region Drag state (Updated by the RaiseDrag***, should not be updated externaly)
+#region Drag state (Updated by the RaiseDrag***, should not be updated externaly)
 		private HashSet<long> _draggingOver;
 
 		/// <summary>
@@ -1329,6 +1332,6 @@ private void ClearDragOver()
 		{
 			_draggingOver?.Clear();
 		}
-		#endregion
+#endregion
 	}
 }