fix: Initial focus on Page #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MartinZikmund
force-pushed
the
dev/mazi/initial-focus
branch
from
86dd200 to
39790b8
Compare
Youssef1313
reviewed
Aug 3, 2021
MartinZikmund
force-pushed
the
dev/mazi/initial-focus
branch
from
39790b8 to
085843e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeromelaban
approved these changes
Sep 9, 2021
ajpinedam
approved these changes
Sep 9, 2021
carldebilly
approved these changes
Sep 9, 2021
MartinZikmund
added
the
ready-to-merge
jeromelaban
reviewed
Sep 10, 2021
Previously, the first focusable child was focused on Page, even if the Page itself was focusable. Now the Page can be focused itself, which matches UWP. In addition, on initial focus we avoid opening the InputPane in case the initial focused element is a TextBox.
MartinZikmund
force-pushed
the
dev/mazi/initial-focus
branch
from
ef23322 to
ae05fa3
Compare
|
@Mergifyio backport release/stable/3.10 |
|
Command
|
jeromelaban
added a commit
that referenced
this pull request
Sep 21, 2021
….10/pr-6651 fix: Initial focus on Page (backport #6651)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #6650
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously, the first focusable child was focused on Page, even if the Page itself was focusable.
What is the new behavior?
Now the Page can be focused itself, which matches UWP. In addition, on initial focus we avoid opening the InputPane in case the initial focused element is a TextBox.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.