Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing global:: qualifier in the BindableMetadataGenerator #616

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

jeromelaban
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

A recent type addition makes application ending in Uno conflict with existing types.

What is the new behavior?

The BindableMetadataGenerator now qualifies property types properly.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):
https://nventive.visualstudio.com/Umbrella/_workitems/edit/147530

@jeromelaban jeromelaban force-pushed the dev/jela/missing-global-bindablemetadata branch from a57c42e to 3865bc9 Compare February 20, 2019 21:36
@jeromelaban jeromelaban merged commit 979317b into master Feb 21, 2019
@carldebilly carldebilly deleted the dev/jela/missing-global-bindablemetadata branch February 28, 2019 15:53
agneszitte pushed a commit that referenced this pull request Sep 2, 2021
agneszitte pushed a commit that referenced this pull request Sep 2, 2021
agneszitte added a commit that referenced this pull request Sep 2, 2021
Fix(Border): Adjust UI Test snapshots differences after changes for pull request 6898 (Related to Uno.Themes - #616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants