-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popup): Put Popup in Parent hierarchy of its Child content #5944
Conversation
The build 28228 found UI Test snapshots differences: Details
|
The build 28228 found UI Test snapshots differences: Details
|
The build 28228 found UI Test snapshots differences: Details
|
The build 28228 found UI Test snapshots differences: Details
|
The build 28228 found UI Test snapshots differences: Details
|
The build 28228 found UI Test snapshots differences: Details
|
765a2b6
to
fe45512
Compare
The build 28393 found UI Test snapshots differences: Details
|
The build 28393 found UI Test snapshots differences: Details
|
The build 28393 found UI Test snapshots differences: Details
|
The build 28393 found UI Test snapshots differences: Details
|
The build 28393 found UI Test snapshots differences: Details
|
Should we add runtime test for this one ? |
The build 28453 found UI Test snapshots differences: Details
|
0f1fbad
to
7647f47
Compare
The build 28460 found UI Test snapshots differences: Details
|
The build 28460 found UI Test snapshots differences: Details
|
The build 28460 found UI Test snapshots differences: Details
|
Set Popup as Parent of PopupPanel. This emulates UWP behavior that the Popup is a Parent of one of the parents of the Child content, which is relied upon in some cases (eg WCT DataGrid relies upon this for focus management).
On these platforms, changing the real Parent to be other than the visual parent breaks the current pointer implementation. As a workaround, we just override the publicly-visible FE.Parent value, without actually changing Store.Parent.
7647f47
to
4b545f6
Compare
The build 28484 found UI Test snapshots differences: Details
|
The build 28484 found UI Test snapshots differences: Details
|
The build 28484 found UI Test snapshots differences: Details
|
The build 28484 found UI Test snapshots differences: Details
|
The build 28484 found UI Test snapshots differences: Details
|
The build 28484 found UI Test snapshots differences: Details
|
Use GetVisualTreeParent() to ascend the tree, since GetParent() may refer to the logical rather than visual parent.
f0dbc64
to
3ed804c
Compare
The build 28634 found UI Test snapshots differences: Details
|
The build 28634 found UI Test snapshots differences: Details
|
The build 28634 found UI Test snapshots differences: Details
|
The build 28642 found UI Test snapshots differences: Details
|
The build 28642 found UI Test snapshots differences: Details
|
The build 28642 found UI Test snapshots differences: Details
|
The build 28664 found UI Test snapshots differences: Details
|
The build 28664 found UI Test snapshots differences: Details
|
The build 28664 found UI Test snapshots differences: Details
|
The build 28664 found UI Test snapshots differences: Details
|
Fix regression introduced by #5944 . TransformToVisual() is now calculated correctly for elements within the hierarchy of a ListView, accounting for the presence of intermediate native elements.
Fix regression introduced by #5944 . TransformToVisual() is now calculated correctly for elements within the hierarchy of a ListView, accounting for the presence of intermediate native elements.
GitHub Issue (If applicable): fixes #5852
Set Popup as Parent of PopupPanel. This emulates UWP behavior that the Popup is a Parent of one of the parents of the Child content, which is relied upon in some cases (eg WCT DataGrid relies upon this for focus management).
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):