Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ConnectionProfile de-obsoleting #5597

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

pkar70
Copy link
Contributor

@pkar70 pkar70 commented Mar 29, 2021

GitHub Issue (If applicable): #5659

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

a) Setting IsWlanConnectionProfile / IsWwanConnectionProfile used API marked as obsolete.
b) GetConnectionCost() uses API available > 16, without checking Android version.

What is the new behavior?

a) For newer Android (>22), setting these fields use other API.
b) For early Androids, returns NetworkCostType.Unknown (instead of exception).

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@pkar70 pkar70 requested a review from a team March 29, 2021 12:09
@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2021

@jeromelaban
Copy link
Member

Thanks for the PR. Don't push empty commits, just do a rebase and squash your commits.

@pkar70
Copy link
Contributor Author

pkar70 commented Mar 30, 2021

I think this is not from my PR: Error : Removed method System.Void Windows.UI.Xaml.DependencyObjectStore.SetResourceBinding(Windows.UI.Xaml.DependencyProperty dependencyProperty, System.Object resourceKey, System.Boolean isTheme, System.Object context) not found in ignore set.

@pkar70 pkar70 force-pushed the ConnectionProfileDeObsolete branch from 0444283 to f72cadd Compare March 30, 2021 13:15
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution !

@jeromelaban jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Jun 1, 2021
@pkar70 pkar70 force-pushed the ConnectionProfileDeObsolete branch from ee6119f to 77751ab Compare June 1, 2021 13:49
@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2021

@mergify mergify bot merged commit 540091f into unoplatform:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants