-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ConnectionProfile de-obsoleting #5597
Conversation
src/Uno.UWP/Networking/Connectivity/ConnectionProfile.Android.cs
Outdated
Show resolved
Hide resolved
Thanks for the PR. Don't push empty commits, just do a rebase and squash your commits. |
I think this is not from my PR: |
0444283
to
f72cadd
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution !
src/Uno.UWP/Networking/Connectivity/ConnectionProfile.Android.cs
Outdated
Show resolved
Hide resolved
ee6119f
to
77751ab
Compare
GitHub Issue (If applicable): #5659
PR Type
What kind of change does this PR introduce?
What is the current behavior?
a) Setting IsWlanConnectionProfile / IsWwanConnectionProfile used API marked as obsolete.
b) GetConnectionCost() uses API available > 16, without checking Android version.
What is the new behavior?
a) For newer Android (>22), setting these fields use other API.
b) For early Androids, returns NetworkCostType.Unknown (instead of exception).
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):