Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vs): Ensure that infobars get closed properly #18606

Merged
merged 2 commits into from
Oct 29, 2024
+135 −53

chore: Adjust for nullable check

2eb79c2
Select commit
Loading
Failed to load commit list.
Merged

fix(vs): Ensure that infobars get closed properly #18606

chore: Adjust for nullable check
2eb79c2
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Oct 29, 2024 in 0s

Your pull request is up to standards!

Codacy found no issues in your code

Annotations

Check warning on line 17 in src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs#L17 

Make '_infoBars' 'readonly'.

Check failure on line 60 in src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs#L60 

Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion.

Check warning on line 78 in src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.RemoteControl.VS/Notifications/InfoBar.cs#L78 

Make '_infoBarFactory' 'readonly'.
View more details on Codacy Production