Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround non-UIElement UIViews in Grid layout (backport #18470) #18484

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

GitHub Issue (If applicable): closes #17997, closes #14013

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Focusing a text input on iOS causes the framework to temporarily add a non-UIElement child to the parent's Grid, which is then surfaced to the Grid as a null

What is the new behavior?

No longer crashing. This is a workaround, ideally we would want to ensure that Children as a UIElementCollection only reflects the actual UIElements in the ChildrenShadow. This however means more complex logic to properly handle indexes, etc. This workaround seems to be sufficient for now to handle the cases we encountered. Created #18474 to track this

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #18470 done by [Mergify](https://mergify.com).

@jeromelaban jeromelaban merged commit f79ae58 into release/stable/5.4 Oct 16, 2024
21 of 59 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.4/pr-18470 branch October 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants