fix: Workaround non-UIElement UIViews in Grid layout (backport #18470) #18484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #17997, closes #14013
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Focusing a text input on iOS causes the framework to temporarily add a non-UIElement child to the parent's
Grid
, which is then surfaced to theGrid
as anull
What is the new behavior?
No longer crashing. This is a workaround, ideally we would want to ensure that
Children
as aUIElementCollection
only reflects the actualUIElements
in theChildrenShadow
. This however means more complex logic to properly handle indexes, etc. This workaround seems to be sufficient for now to handle the cases we encountered. Created #18474 to track thisPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):
This is an automatic backport of pull request #18470 done by [Mergify](https://mergify.com).