fix(Button): Command binding resetting on CanExecution exception (backport #18378) #18388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 82846ba)
6 tasks
jeromelaban
approved these changes
Oct 4, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18388/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18388/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes unoplatform/kahua-private#199
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If Button::Command binding produces an ICommand value that throws Exception in its CanExecute, this value will be canceled and replaced by the Binding::FallbackValue. This does not happen on windows.
What is the new behavior?
^ should not happen anymore.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.This is an automatic backport of pull request fix(Button): Command binding resetting on CanExecution exception #18378 done by Mergify.