Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid TFM error on SamplesApp.UITests #18036

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: Avoid TFM error on SamplesApp.UITests #18036

merged 1 commit into from
Sep 30, 2024

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When targeting .NET 8 tfm override VS complains that the project targets .NET 9

What is the new behavior?

Adjusted.

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund changed the title fix: Avoid error on SamplesApp.UITests fix: Avoid TFM error on SamplesApp.UITests Aug 27, 2024
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Aug 27, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18036/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18036/index.html

Youssef1313
Youssef1313 reviewed Aug 27, 2024
View reviewed changes
src/SamplesApp/SamplesApp.UITests/SamplesApp.UITests.csproj Outdated
@@ -11,6 +11,8 @@
<NoWarn>$(NoWarn);SYSLIB1045;CS1998</NoWarn>
</PropertyGroup>

<Import Project="../../targetframework-override-noplatform.props" />
Copy link
Member

@Youssef1313 Youssef1313 Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be kept as NetPrevious (without override). CI may complain that the .NET 8 runtime isn't installed, in this case we can just add a step that installs the runtime.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18036/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18036/index.html

@MartinZikmund MartinZikmund self-assigned this Aug 28, 2024
@MartinZikmund MartinZikmund force-pushed the dev/mazi/uitest-error branch from 43bea68 to c1a24f6 Compare August 29, 2024 14:07
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18036/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18036/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/uitest-error branch from c1a24f6 to 0641657 Compare August 30, 2024 12:48
@MartinZikmund MartinZikmund disabled auto-merge August 30, 2024 12:48
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18036/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18036/index.html

@jeromelaban jeromelaban merged commit 334581d into master Sep 30, 2024
77 of 101 checks passed
@jeromelaban jeromelaban deleted the dev/mazi/uitest-error branch September 30, 2024 12:54
@jeromelaban jeromelaban mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@MartinZikmund MartinZikmund

Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinZikmund @unodevops @jeromelaban @Youssef1313