[Performance] Replaced FindIndex in RecyclePool.TryGetElementCore with For loop #17261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
reviewed
Jun 21, 2024
Comment on lines
+71
to
+79
| var iter=-1; | ||
| for (int i = 0; i < elements.Count; i++) | ||
| { | ||
| if ((elemInfo.Owner == winrtOwner) || (elemInfo.Owner == null)) | ||
| { | ||
| iter=i; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Thanks! Could you move this to another method for readability?
carldebilly
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #15806
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In RecyclePool when an iterator is created it uses a FindIndex expression which is inefficient
What is the new behavior?
Replaced FindIndex with a For loop
var iter = elements.FindIndex(elemInfo => elemInfo.Owner == winrtOwner || elemInfo.Owner == null);with
for (int i = 0; i < elements.Count; i++) { if ((elemInfo.Owner == winrtOwner) || (elemInfo.Owner == null)) { iter=i; break; } }PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):