[DRAFT] #16832
Closed
[DRAFT] #16832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/wasm 🌐
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16832/index.html |
|
The build 125928 found UI Test snapshots differences: Details
|
dr1rrb
reviewed
May 22, 2024
| @@ -286,7 +286,6 @@ internal override void OnLayoutUpdated() | |||
| if (_rootEltUsedToProcessScrollTo is null && rootElement is FrameworkElement rootFwElt) | |||
| { | |||
| _rootEltUsedToProcessScrollTo = rootFwElt; | |||
| rootFwElt.LayoutUpdated += TryProcessScrollTo; | |||
| } | |||
There was a problem hiding this comment.
This has been added for the CalendarView that was requesting to scroll to a given offset even before the ScrollViewer has been added into the visual tree. (It has been has been added by this commit 819e28e which is part of the massive CalendarView PR : #6098).
It might not be needed with your last changes, but I'm not sure that there are tests for this ... you should check manually if there is nothing broken (on at least a chromium based browser and Firefox).
There was a problem hiding this comment.
Let's keep for now then and revisit if proven to be problematic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):