Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use Array.Clear(arr) instead of Array.Clear(arr, 0, arr.Length) #14978

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #13136

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14978/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14978/index.html

Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I see this method Array.Clear(Array) was added in .NET 6.

@jeromelaban jeromelaban merged commit af7f5c1 into unoplatform:master Jan 8, 2024
85 checks passed
@Youssef1313 Youssef1313 deleted the array-clear-perf branch January 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usages of Array.Clear(arr, 0, arr.Length) with Array.Clear(arr)
4 participants