Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust TextBox ScrollViewer workaround for Material TextBox to wrap properly #14297

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 6, 2023

GitHub Issue (If applicable): closes #14267

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 398059c

This pull request fixes some Android style issues with the TextBox control and adds unit tests to verify its TextWrapping behavior. It also removes some redundant code from the TextBox class and its Android-specific file. It adds a new XAML page and its code-behind file to support one of the unit tests.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Nov 6, 2023
@jeromelaban jeromelaban merged commit 93f6b63 into unoplatform:master Nov 7, 2023
86 checks passed
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.0

Copy link
Contributor

mergify bot commented Nov 7, 2023

backport release/stable/5.0

🟠 Pending

  • Backport to branch release/stable/5.0 in progress

@Youssef1313 Youssef1313 deleted the issues/14267 branch November 7, 2023 15:25
@jeromelaban
Copy link
Member

https://github.com/Mergifyio backport release/stable/5.0

Copy link
Contributor

mergify bot commented Nov 10, 2023

backport release/stable/5.0

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Nov 10, 2023
…5.0/pr-14297

fix: Adjust TextBox ScrollViewer workaround for Material TextBox to wrap properly (backport #14297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Android] TextBox content not wrapping
2 participants