-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(itemspresenter): add support for footer and header, as well as irregular snap points #13507
Merged
jeromelaban
merged 22 commits into
unoplatform:master
from
ramezgerges:header_footer_presenter
Sep 18, 2023
Merged
feat(itemspresenter): add support for footer and header, as well as irregular snap points #13507
jeromelaban
merged 22 commits into
unoplatform:master
from
ramezgerges:header_footer_presenter
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramezgerges
changed the title
Header footer presenter
feat(itemspresenter): add support for footer and header, as well as irregular snap points
Sep 5, 2023
Youssef1313
reviewed
Sep 5, 2023
github-actions
bot
added
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/macos 🍏
Categorizes an issue or PR as relevant to the macOS platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
labels
Sep 5, 2023
ramezgerges
force-pushed
the
header_footer_presenter
branch
from
September 5, 2023 21:20
d9fea0e
to
7964d01
Compare
Youssef1313
reviewed
Sep 6, 2023
Youssef1313
reviewed
Sep 6, 2023
github-actions
bot
added
area/build
Categorizes an issue or PR as relevant to build infrastructure
area/automation
Categorizes an issue or PR as relevant to project automation
labels
Sep 6, 2023
jeromelaban
reviewed
Sep 6, 2023
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ItemsPresenter.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
area/automation
Categorizes an issue or PR as relevant to project automation
label
Sep 9, 2023
ramezgerges
force-pushed
the
header_footer_presenter
branch
3 times, most recently
from
September 10, 2023 13:48
481bb93
to
807f9a8
Compare
jeromelaban
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes remaining, but looks good!
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ItemsPresenter.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ItemsPresenter.cs
Show resolved
Hide resolved
Very nice! There are a few tests like Line 90 in 85ad12d
|
github-actions
bot
added
the
area/automation
Categorizes an issue or PR as relevant to project automation
label
Sep 13, 2023
ramezgerges
force-pushed
the
header_footer_presenter
branch
from
September 13, 2023 22:30
d0c3466
to
ffe314b
Compare
@ramezgerges There's one test that fails:
|
…Presenter and StackPanel
…hat instead of UIElementCollection in ItemsPresenter
…istViews on Android
Header/Footer weren't implemented
ramezgerges
force-pushed
the
header_footer_presenter
branch
from
September 15, 2023 22:06
25f2fa9
to
cf53928
Compare
ramezgerges
force-pushed
the
header_footer_presenter
branch
from
September 15, 2023 22:47
b75a3df
to
0d8aa8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/automation
Categorizes an issue or PR as relevant to project automation
area/build
Categorizes an issue or PR as relevant to build infrastructure
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
platform/macos 🍏
Categorizes an issue or PR as relevant to the macOS platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #10745, closes #13248
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 10f86b8
This pull request improves the
StackPanel
andItemsPresenter
controls in Uno Platform by fixing snap point calculation, adding header and footer support, and increasing test coverage. It also simplifies the use of theWindowHelper
class in theStackPanel
unit tests and refactors some common code.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):