Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vs): Restore intellisense for non-windows targets #13376

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Aug 23, 2023

GitHub Issue (If applicable): closes #11571, closes #8774

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Visual Studio 2022 17.7 and later recognizes the XAML tags intellisense.

Copilot Summary

🤖 Generated by Copilot at 6f6d027

Moved XmlnsDefinitionAttribute class to Microsoft.UI.Xaml namespace and removed AssemblyName property. This improves XAML intellisense compatibility with .NET MAUI and avoids conflicts with .NET framework.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@MartinZikmund
Copy link
Member

Epic!

@jeromelaban jeromelaban enabled auto-merge August 24, 2023 12:13
@jeromelaban jeromelaban disabled auto-merge August 24, 2023 13:26
@jeromelaban jeromelaban merged commit 28f56a6 into master Aug 24, 2023
@jeromelaban jeromelaban deleted the dev/jela/intellisense-update branch August 24, 2023 13:26
@jeromelaban
Copy link
Member Author

@Mergifyio backport legacy/4x

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

backport legacy/4x

✅ Backports have been created

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/4.10

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

backport release/stable/4.10

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Aug 24, 2023
…4.10/pr-13376

fix(vs): Restore intellisense for non-windows targets (backport #13376)
jeromelaban added a commit that referenced this pull request Aug 25, 2023
fix(vs): Restore intellisense for non-windows targets (backport #13376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants