fix: ThemeResource bindings are not scope-updated on Style switch
#13016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Jul 26, 2023
Youssef1313
approved these changes
Jul 26, 2023
agneszitte
approved these changes
Jul 26, 2023
Xiaoy312
approved these changes
Jul 26, 2023
|
this should be a backport candidate for 4x |
|
@Xiaoy312 yes, backport will follow up after it is merged 👍 |
|
formatting issue @MartinZikmund |
6 tasks
|
The build 87407 found UI Test snapshots differences: Details
|
|
@Mergifyio backport legacy/4x |
✅ Backports have been created
|
MartinZikmund
added a commit
that referenced
this pull request
Jul 27, 2023
fix: `ThemeResource` bindings are not scope-updated on `Style` switch (backport #13016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #12496
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously only
StaticResourcebindings were re-evaluated whenStylewas applied. This is not enough asThemeResourcesalso need to be sourced from the current scope. In addition, the precedence override needs to be applied only while the setters are being applied, but not for the resource bindings update, otherwise it could also apply base control bindings withExplicitStyleprecedence, even though the bindings have justImplicitStyleprecedence.What is the new behavior?
Fixed!
Copilot Summary
🤖 Generated by Copilot at e51e120
This pull request fixes a bug and adds a test for theme resource resolution in styles. It refactors the
Style.ApplyTomethod to make it more clear and consistent. It also creates a new user control with two styles for a button, one using a theme resource and one using a static resource, and a new test method that asserts that the button's background color changes correctly when the style is switched at runtime.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.