Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HR indicator is using negative margins #18471

Closed
rajamatt opened this issue Oct 15, 2024 · 0 comments · Fixed by #18472
Closed

HR indicator is using negative margins #18471

rajamatt opened this issue Oct 15, 2024 · 0 comments · Fixed by #18472
Assignees
@rajamatt
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@rajamatt
Copy link
Contributor

rajamatt commented Oct 15, 2024 •
edited
Loading

Current behavior

The HR indicator is using -3 margins because the paths of the SVGs its using have a "margin" included in them already. This leads to the HR indicator being offcenter when no extra margin is applied. If we fix the SVG paths, the -3 margins won't be needed anymore.

This also might help with #17837 where we need to use -10 margins.
@rajamatt rajamatt added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 15, 2024
@rajamatt rajamatt self-assigned this Oct 15, 2024
@rajamatt rajamatt mentioned this issue Oct 15, 2024
Merged
@mergify mergify bot mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajamatt rajamatt

Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove negative HR indicator margins unoplatform/uno
1 participant
@rajamatt