Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HotReloadStatusView doesn't show indicator when added to existing UI #17837

Closed
nickrandolph opened this issue Aug 5, 2024 · 4 comments · Fixed by #18270
Closed

HotReloadStatusView doesn't show indicator when added to existing UI #17837

nickrandolph opened this issue Aug 5, 2024 · 4 comments · Fixed by #18270
Assignees
@dr1rrb @rajamatt
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@nickrandolph
Copy link
Contributor

Current behavior

If the HotReloadStatusView is created and added to an existing UI it doesn't show any status indicator (just shows a white square)

Expected behavior

Same indicators are presented as the HotReloadStatusView on the DiagnosticsOverlay

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@nickrandolph nickrandolph added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 5, 2024
@jeromelaban jeromelaban added area/hot-reload Categorizes an issue or PR as relevant to hot reload project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools and removed triage/untriaged Indicates an issue requires triaging or verification labels Aug 26, 2024
@dr1rrb
Copy link
Member

dr1rrb commented Sep 19, 2024

This is because the OnHotReloadStatusChanged() is not invoked (it's expected to be invoked externally by the ClientHotReloadProcessor. We need to provide a public ctor which will self-connect to the ClientHotReloadProcessor.StatusChanged event.

@rajamatt rajamatt self-assigned this Sep 19, 2024
@dr1rrb dr1rrb mentioned this issue Sep 23, 2024
Merged
6 tasks
@dr1rrb
Copy link
Member

dr1rrb commented Sep 23, 2024

@rajamatt I did it as I was working on this file

@mergify mergify bot mentioned this issue Sep 23, 2024
Merged
6 tasks
@dr1rrb dr1rrb reopened this Oct 2, 2024
@dr1rrb
Copy link
Member

dr1rrb commented Oct 2, 2024

Even if now properly init and fed with events, the indicator is still not showing

@rajamatt rajamatt mentioned this issue Oct 3, 2024
Closed
@agneszitte
Copy link
Contributor

agneszitte commented Oct 7, 2024 •
edited
Loading

@nickrandolph additional QA is needed for this issue, please? Properly fixed?

@rajamatt rajamatt mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr1rrb dr1rrb

@rajamatt rajamatt

Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev/dr/dev srv unoplatform/uno
5 participants
@nickrandolph @jeromelaban @dr1rrb @agneszitte @rajamatt