Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorHelper.ToDisplayName not implemented #18004

Closed
Arlodotexe opened this issue Aug 22, 2024 · 0 comments · Fixed by #18017
Closed

ColorHelper.ToDisplayName not implemented #18004

Arlodotexe opened this issue Aug 22, 2024 · 0 comments · Fixed by #18017
Assignees
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@Arlodotexe
Copy link
Contributor

Arlodotexe commented Aug 22, 2024

Current behavior

ColorHelper.ToDisplayName() has been available on UWP for a while, but was recently added to the Windows App SDK in 1.6-preview1.

This API is not implemented in Uno for either WinUI 2/uwp or WinUI 3/wasdk.

Expected behavior

API should be implemented in Uno, matching the platform behavior.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

Third party / don't use the platform ColorHelper API.

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia, Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

Tested on Uno 5.2

Affected platforms

WebAssembly

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@Arlodotexe Arlodotexe added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Aug 22, 2024
@morning4coffe-dev morning4coffe-dev self-assigned this Aug 23, 2024
Arlodotexe added a commit to CommunityToolkit/Windows that referenced this issue Aug 24, 2024
* Fixing CSWinRT1028 warnings, adding partials for AoT.

* Suppress internally generated error CsWinRT1028, add notes

* Updated tooling pointer

* Bump tooling to latest wasdk/1.6

* Fixing FontWeight and FontStyle namespaces

* Update tooling

* Update tooling

* Fixed bad property declaration

* Update Microsoft.WindowsAppSDK to 1.6.240807006-preview1, remove CsWinRT1028 suppression.

* Update WindowsSdkPackageVersion for Wasdk 1.6 preview1

* Update transient WebView2 reference to 1.0.2730-prerelease

* Fixed CsWinRT1028, marked partial for AoT

* Fixed CsWinRT1028, marked partial for AoT

* Revert WindowsSdkPackageVersion to 10.0.22621.37-preview for WindowsAppSDK 1.6 Preview1

* Update tooling with latest CsWinRT1028 fixes

* Update tooling pointer

* Update tooling pointer

* Remove clean task to resolve #457 (comment)

* Implement ColorHelper.ToDisplayName on WinUI 3

* Handle missing ColorHelper.ToDisplayName implementation on Uno. See unoplatform/uno#18004.

* Bump tooling to latest main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants