feat(wasm): Added ability to measure shapes on Wasm even when the con…

…trol is not loaded.
unoplatform · Aug 2, 2021 · fe2c502 · fe2c502
1 parent 0d4e7cf
commit fe2c502
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 2 deletions.
diff --git a/src/Uno.UI/WasmScripts/Uno.UI.js b/src/Uno.UI/WasmScripts/Uno.UI.js
@@ -1439,7 +1439,29 @@ var Uno;
                 return true;
             }
             getBBoxInternal(elementId) {
-                return this.getView(elementId).getBBox();
+                const element = this.getView(elementId);
+                let unconnectedRoot = null;
+                let cleanupUnconnectedRoot = (owner) => {
+                    if (unconnectedRoot !== null) {
+                        owner.removeChild(unconnectedRoot);
+                    }
+                };
+                try {
+                    // On FireFox, the element needs to be connected to the DOM
+                    // or the getBBox() will crash.
+                    if (!element.isConnected) {
+                        while (unconnectedRoot.parentElement) {
+                            // Need to find the top most "unconnected" parent
+                            // of this element
+                            unconnectedRoot = unconnectedRoot.parentElement;
+                        }
+                        this.containerElement.appendChild(unconnectedRoot);
+                    }
+                    return element.getBBox();
+                }
+                finally {
+                    cleanupUnconnectedRoot(this.containerElement);
+                }
             }
             setSvgElementRect(pParams) {
                 const params = WindowManagerSetSvgElementRectParams.unmarshal(pParams);

diff --git a/src/Uno.UI/ts/WindowManager.ts b/src/Uno.UI/ts/WindowManager.ts
@@ -1435,7 +1435,37 @@ namespace Uno.UI {
 		}
 
 		private getBBoxInternal(elementId: number): any {
-			return (<any>this.getView(elementId)).getBBox();
+
+			const element = this.getView(elementId) as SVGGraphicsElement;
+			let unconnectedRoot: HTMLElement = null;
+
+			let cleanupUnconnectedRoot = (owner: HTMLDivElement) => {
+				if (unconnectedRoot !== null) {
+					owner.removeChild(unconnectedRoot);
+				}
+			}
+
+			try {
+
+				// On FireFox, the element needs to be connected to the DOM
+				// or the getBBox() will crash.
+				if (!element.isConnected) {
+
+					while (unconnectedRoot.parentElement) {
+						// Need to find the top most "unconnected" parent
+						// of this element
+						unconnectedRoot = unconnectedRoot.parentElement as HTMLElement;
+					}
+
+					this.containerElement.appendChild(unconnectedRoot);
+				}
+
+				return element.getBBox();
+			}
+			finally {
+				cleanupUnconnectedRoot(this.containerElement);
+			}
+
 		}
 
 		public setSvgElementRect(pParams: number): boolean {