Merge pull request #8220 from MartinZikmund/dev/mazi/ref-impl-comparer

refactor: Write `ReferenceImplComparer` error messages to Error output
unoplatform · Mar 7, 2022 · 4d3e8b5 · 4d3e8b5
2 parents 96e801f + 5755089
commit 4d3e8b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Uno.ReferenceImplComparer/Program.cs b/src/Uno.ReferenceImplComparer/Program.cs
@@ -61,7 +61,7 @@ private static bool CompareAssemblies(AssemblyDefinition referenceAssemby, Assem
 						// and that the hierarchy will be adjusted for wasm to match skia.
 						&& referenceType.BaseType?.FullName != "Windows.UI.Xaml.Shapes.ArbitraryShapeBase")
 					{
-						Console.WriteLine($"{referenceType.FullName} base type is different {referenceType.BaseType?.FullName} in reference, {runtimeType.BaseType?.FullName} in {identifier}");
+						Console.Error.WriteLine($"Error: {referenceType.FullName} base type is different {referenceType.BaseType?.FullName} in reference, {runtimeType.BaseType?.FullName} in {identifier}");
 						hasError = true;
 					}
 
@@ -72,8 +72,8 @@ private static bool CompareAssemblies(AssemblyDefinition referenceAssemby, Assem
 				}
 				else
 				{
+					Console.Error.WriteLine($"Error: The type {referenceType} is missing from ");
 					hasError = true;
-					Console.WriteLine($"The type {referenceType} is missing from ");
 				}
 			}
 
@@ -89,7 +89,7 @@ private static bool CompareMembers(IEnumerable<MemberReference> referenceMembers
 			{
 				if (!runtimeMembersLookup.ContainsKey(referenceMember.ToString()))
 				{
-					Console.WriteLine($"The member {referenceMember} cannot be found in {identifier}");
+					Console.Error.WriteLine($"Error: The member {referenceMember} cannot be found in {identifier}");
 					hasError = true;
 				}
 			}

diff --git a/src/Uno.UI-Tools.slnf b/src/Uno.UI-Tools.slnf
@@ -6,6 +6,7 @@
       "ResourceConverter\\ResourceConverter.csproj",
       "T4Generator\\T4Generator.csproj",
       "UWPUsageStatsGenerator\\UWPUsageStatsGenerator.csproj",
+      "Uno.ReferenceImplComparer\\Uno.ReferenceImplComparer.csproj",
       "Uno.UI.AssemblyComparer\\Uno.UI.AssemblyComparer.csproj",
       "Uno.UI.TestComparer\\Uno.UI.TestComparer.csproj",
       "Uno.UWPSyncGenerator.Reference\\Uno.UWPSyncGenerator.Reference.csproj",