fix(responsive): invalid initial value being returned #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #998
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ResponsiveExtension (binding) is returning the initial default value created by Activator.CreateInstance when the size is not available. This can cause a problem where the default value of said type is not a valid value, such as a the case for Grid.RowSpan.
User defined enums cannot be parsed.
What is the new behavior?
The initial default value returned will now be the first member defined within: Narrowest...Widest. The reasoning being that, if it is defined it has to be more valid than just the
default(T)
.User defined enums can now be parsed by ResponsiveExtension correctly.
PR Checklist
Please check if your PR fulfills the following requirements: