Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SafeArea on Android 15 #1336

Closed
wants to merge 5 commits into from
Closed

fix: SafeArea on Android 15 #1336

wants to merge 5 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Feb 10, 2025

GitHub Issue (If applicable): closes #1337

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1336.eastus2.azurestaticapps.net

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use xamlstyler's format document here
to re-align the attributes

@unodevops
Copy link

⚠️⚠️ The build 154628 has failed on Uno Toolkit - CI.

@kazo0
Copy link
Contributor

kazo0 commented Feb 11, 2025

@Mergifyio backport release/stable/6.4

Copy link
Contributor

mergify bot commented Feb 11, 2025

backport release/stable/6.4

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@kazo0
Copy link
Contributor

kazo0 commented Feb 11, 2025

@MartinZikmund looks like we'll need to bump the android sdks downloaded for the uitests:

/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.Android.Sdk.Darwin/34.0.95/tools/Xamarin.Android.Tooling.targets(100,5): error XA5207: Could not find android.jar for API level 35. This means the Android SDK platform for API level 35 is not installed; it was expected to be in /Users/runner/work/1/s/build/android-sdk/platforms/android-35/android.jar. [/Users/runner/work/1/s/samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Mobile/Uno.Toolkit.Samples.Mobile.csproj::TargetFramework=net8.0-android]

echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install 'build-tools;34.0.0' | tr '\r' '\n' | uniq
echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install 'platforms;android-34' | tr '\r' '\n' | uniq
echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install "platforms;android-$ANDROID_SIMULATOR_APILEVEL" | tr '\r' '\n' | uniq
echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install 'extras;android;m2repository' | tr '\r' '\n' | uniq
echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install 'system-images;android-34;google_apis_playstore;x86_64' | tr '\r' '\n' | uniq
echo "y" | $LATEST_CMDLINE_TOOLS_PATH/bin/sdkmanager --sdk_root=${ANDROID_HOME} --install "system-images;android-$ANDROID_SIMULATOR_APILEVEL;google_apis_playstore;x86_64" | tr '\r' '\n' | uniq

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1336.eastus2.azurestaticapps.net

@unodevops
Copy link

⚠️⚠️ The build 154881 has failed on Uno Toolkit - CI.

@jeromelaban
Copy link
Member

The issue is fixed in API 35:

image

But on a tablan API 34, it's behaving a bit weird:

image

The app bar is lowered for some reason.

@jeromelaban
Copy link
Member

@MartinZikmund looks like we'll need to bump the android sdks downloaded for the uitests:

Looking at this now.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1336.eastus2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SafeArea is not working correctly on Android 15 and newer
5 participants