feat: Adding ProgressRing extension #1002
Conversation
nickrandolph
force-pushed
the
dev/nr/stopprogressring
branch
from
0368c89 to
86d4c6f
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/LoadingViewSample.xaml
Outdated
Show resolved
Hide resolved
nickrandolph
force-pushed
the
dev/nr/stopprogressring
branch
from
7e70837 to
1aee150
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1002.eastus2.azurestaticapps.net |
|
@nickrandolph should this be backported? |
|
It can be, but it's new so can go into 5.2 unless needed prior |
|
@kazo0 I think given the performance implication this has (ie progress ring continues to run after splash screen), I'll back port it. |
|
@mergify backport release/stable/5.1 |
✅ Backports have been created
|
….1/pr-1002 feat: Adding ProgressRing extension (backport #1002)
Fixes: https://github.com/unoplatform/uno.chefs/issues/835
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ProgressRing contained within the loading template doesn't ever stop (ie IsActive is true)
What is the new behavior?
New ProgressRingExtensions.IsActive can be used to start/stop all nested ProgressRings
In VisualState for Loading/Loaded any ProgressRings can have IsActive set to true/false
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):