ci: Fix artifact handling for GitHub Actions v4 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated artifact upload steps to assign unique names (NuGet-Fluent, NuGet-Roboto, NuGet-OpenSans) to address changes introduced in actions/upload-artifact@v4. - Modified publish job to download artifacts by job-scoped names into separate directories (artifacts/fluent, artifacts/roboto, artifacts/opensans). - Adjusted signing and pushing steps to ensure consistent handling of artifacts across jobs and publishing.
agneszitte
requested review from
jeromelaban,
Youssef1313 and
MartinZikmund
|
@MartinZikmund PR to fix the current publication issue to follow up on your release request here |
Youssef1313
previously approved these changes
Sep 12, 2024
kazo0
approved these changes
Sep 12, 2024
jeromelaban
approved these changes
Sep 13, 2024
agneszitte
added a commit
that referenced
this pull request
Sep 13, 2024
7 tasks
agneszitte
added a commit
that referenced
this pull request
Sep 13, 2024
ci: Adjust SignClient after #52
7 tasks
|
@Mergifyio backport release/stable/2.4 |
✅ Backports have been created
|
7 tasks
|
@Mergifyio backport release/stable/2.4 |
✅ Backports have been created
|
agneszitte
added a commit
that referenced
this pull request
Sep 13, 2024
…/pr-52 ci: Fix artifact handling for GitHub Actions v4 (backport #52)
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
(cherry picked from commit 28e5384)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
With latest change to update to download-artifact and upload-artifact to v4, only 1 artifact is now downloaded for the publication
Related previous PR: ci: Update download-artifact and upload-artifact to v4 #51
What is the new behavior?
Note
Related details:
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.