Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): adding other elements to lightweight styling #1070

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

@Marc-Antoine-Soucy Marc-Antoine-Soucy commented Jul 20, 2023

GitHub Issue: ##992

PR Type

What kind of change does this PR introduce?

  • Feature

Description

Added some resources to the themedictionnary and changed the look so that it is closer to figma

Added resources to the lightweight styling

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

image
image

Other information

Internal Issue (If applicable):

#992

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review July 20, 2023 16:12
@Marc-Antoine-Soucy
Copy link
Contributor Author

The reason the whole page changes is because it goes from space -> tabs

Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you split it into 2 commits?
one with formatting and commit as: "style: fix tabs"
and then your actual changes as is

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/lightweightslider branch from 193514b to f66f5fa Compare July 20, 2023 16:26
@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/lightweightslider branch from f66f5fa to fa0f009 Compare July 20, 2023 16:28
@Marc-Antoine-Soucy
Copy link
Contributor Author

could you split it into 2 commits? one with formatting and commit as: "style: fix tabs" and then your actual changes as is

Should be good now

@kazo0 kazo0 merged commit a702b03 into master Jul 20, 2023
@kazo0 kazo0 deleted the dev/maso/lightweightslider branch July 20, 2023 18:19
@agneszitte
Copy link
Contributor

agneszitte commented Jul 21, 2023

https://github.com/Mergifyio backport legacy/2x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link

mergify bot commented Jul 21, 2023

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 21, 2023
* style: fix tabs

* feat(slider): adding other elements to lightweight styling

(cherry picked from commit a702b03)
agneszitte added a commit that referenced this pull request Jul 24, 2023
feat(slider): adding other elements to lightweight styling (backport #1070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants