-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slider): adding other elements to lightweight styling #1070
Conversation
The reason the whole page changes is because it goes from space -> tabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you split it into 2 commits?
one with formatting and commit as: "style: fix tabs"
and then your actual changes as is
193514b
to
f66f5fa
Compare
f66f5fa
to
fa0f009
Compare
Should be good now |
https://github.com/Mergifyio backport legacy/2x
|
✅ Backports have been created
|
* style: fix tabs * feat(slider): adding other elements to lightweight styling (cherry picked from commit a702b03)
feat(slider): adding other elements to lightweight styling (backport #1070)
GitHub Issue: ##992
PR Type
What kind of change does this PR introduce?
Description
Added some resources to the themedictionnary and changed the look so that it is closer to figma
Added resources to the lightweight styling
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):
#992