Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(navigationview): Add lightweight styling to navigation view style (mux) #1028

Merged
merged 1 commit into from
Jun 27, 2023
Merged

refactor(navigationview): Add lightweight styling to navigation view style (mux) #1028

merged 1 commit into from
Jun 27, 2023

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented Jun 7, 2023 •
edited by kazo0
Loading

closes #1019
related #963
GitHub Issue: #1019

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Description

image
image

Overriden:
image
image

Overriden with:

<Page.Resources>
    <!-- Brushes -->
    <SolidColorBrush x:Key="NavigationViewBackground" Color="Red" />
    <SolidColorBrush x:Key="NavigationViewDefaultPaneBackground" Color="Orange" />
    <SolidColorBrush x:Key="NavigationViewPaneBackground" Color="Yellow" />

    <SolidColorBrush x:Key="NavigationViewDefaultPaneBorderBrush" Color="Green" />

    <SolidColorBrush x:Key="NavigationViewButtonForeground" Color="Blue" />
    <SolidColorBrush x:Key="NavigationViewButtonForegroundPointerOver" Color="Indigo" />
    <SolidColorBrush x:Key="NavigationViewButtonForegroundPressed" Color="Pink" />
    <SolidColorBrush x:Key="NavigationViewButtonForegroundDisabled" Color="Red" />

    <SolidColorBrush x:Key="NavigationViewButtonBackgroundPointerOver" Color="Orange" />
    <SolidColorBrush x:Key="NavigationViewButtonBackgroundPressed" Color="Yellow" />

    <SolidColorBrush x:Key="NavigationViewButtonRippleFeedback" Color="Green" />

    <SolidColorBrush x:Key="NavigationViewItemBackgroundPointerOver" Color="Blue" />
    <SolidColorBrush x:Key="NavigationViewItemBackgroundPressed" Color="Indigo" />
    <SolidColorBrush x:Key="NavigationViewItemBackgroundDisabled" Color="Pink" />
    <SolidColorBrush x:Key="NavigationViewItemBackgroundSelected" Color="Red" />

    <SolidColorBrush x:Key="NavigationViewItemForeground" Color="Orange" />

    <SolidColorBrush x:Key="NavigationViewItemSeparatorForeground" Color="Yellow" />

    <SolidColorBrush x:Key="NavigationViewItemRippleFeedback" Color="Green" />
</Page.Resources>

PR Checklist

  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

@nguyeenvy nguyeenvy requested a review from kazo0 June 7, 2023 21:55
@nguyeenvy nguyeenvy self-assigned this Jun 7, 2023
@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-NavigationView-Style-2 branch from 0ed291b to b3fe535 Compare June 7, 2023 21:57
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 self-requested a review June 8, 2023 00:39
@github-actions
Copy link

github-actions bot commented Jun 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-NavigationView-Style-2 branch from 86f465d to f9d26eb Compare June 14, 2023 18:27
@github-actions
Copy link

github-actions bot commented Jun 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Jun 19, 2023

lgtm, @Xiaoy312 wanna take a quick look, does this affect any of the work you had going on for this?

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-NavigationView-Style-2 branch from d9f8900 to ca286f8 Compare June 19, 2023 19:33
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1028.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 2a018e2 into master Jun 27, 2023
@kazo0 kazo0 deleted the dev/vyng/Lightweight-Styling-NavigationView-Style-2 branch June 27, 2023 17:08
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 31, 2023 •
edited
Loading

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@nguyeenvy @mergify
refactor(navigationview): Add lightweight styling to navigation view …
11ce0b4 
…style (mux) (#1028)

(cherry picked from commit 2a018e2)

# Conflicts:
#	src/library/Uno.Material/Styles/Controls/v2/NavigationView.xaml
@mergify mergify bot mentioned this pull request Jul 31, 2023
Closed
@jeromelaban jeromelaban mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

Assignees

@nguyeenvy nguyeenvy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Material] Lightweight Styling - NavigationView Styles
3 participants
@nguyeenvy @kazo0 @agneszitte