Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(textbox): Add the Lightweight Styling Text Box Style #1002

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented May 26, 2023

closes #988

GitHub Issue: #988

PR Type

  • Refactoring (no functional changes, no api changes)

Description

TextBox.xaml has been modified. New resources have been created for overriding in other pages.
Filled
image
image

Outlined
image
image

Locally overridden with:

<Page.Resources>
	<!--#region Filled Text Box Brushes-->
	<SolidColorBrush x:Key="FilledTextBoxBackground"
					 Color="Red" />
	<SolidColorBrush x:Key="FilledTextBoxBackgroundPointerOver"
					 Color="Orange" />
	<SolidColorBrush x:Key="FilledTextBoxBackgroundFocused"
					 Color="Yellow" />
	<SolidColorBrush x:Key="FilledTextBoxBackgroundDisabled"
					 Color="Green" />

	<SolidColorBrush x:Key="FilledTextBoxBorderBrush"
					 Color="Blue" />
	<SolidColorBrush x:Key="FilledTextBoxBorderBrushPointerOver"
					 Color="Indigo" />
	<SolidColorBrush x:Key="FilledTextBoxBorderBrushFocused"
					 Color="Pink" />
	<SolidColorBrush x:Key="FilledTextBoxBorderBrushDisabled"
					 Color="Red" />

	<SolidColorBrush x:Key="FilledTextBoxDeleteButtonForeground"
					 Color="Orange" />
	<SolidColorBrush x:Key="FilledTextBoxDeleteButtonForegroundPointerOver"
					 Color="Yellow" />
	<SolidColorBrush x:Key="FilledTextBoxDeleteButtonForegroundFocused"
					 Color="Green" />
	<SolidColorBrush x:Key="FilledTextBoxDeleteButtonForegroundDisabled"
					 Color="Blue" />

	<SolidColorBrush x:Key="FilledTextBoxForeground"
					 Color="Indigo" />
	<SolidColorBrush x:Key="FilledTextBoxForegroundPointerOver"
					 Color="Pink" />
	<SolidColorBrush x:Key="FilledTextBoxForegroundFocused"
					 Color="Red" />
	<SolidColorBrush x:Key="FilledTextBoxForegroundDisabled"
					 Color="Orange" />

	<SolidColorBrush x:Key="FilledTextBoxPlaceholderForeground"
					 Color="Yellow" />
	<SolidColorBrush x:Key="FilledTextBoxPlaceholderForegroundPointerOver"
					 Color="Green" />
	<SolidColorBrush x:Key="FilledTextBoxPlaceholderForegroundFocused"
					 Color="Blue" />
	<SolidColorBrush x:Key="FilledTextBoxPlaceholderForegroundDisabled"
					 Color="Indigo" />
	<!--#endregion-->

	<!--#region Outlined Text Box Brushes-->
	<SolidColorBrush x:Key="OutlinedTextBoxBorderBrush"
					 Color="Pink" />
	<SolidColorBrush x:Key="OutlinedTextBoxBorderBrushPointerOver"
					 Color="Red" />
	<SolidColorBrush x:Key="OutlinedTextBoxBorderBrushFocused"
					 Color="Orange" />
	<SolidColorBrush x:Key="OutlinedTextBoxBorderBrushDisabled"
					 Color="Yellow" />

	<SolidColorBrush x:Key="OutlinedTextBoxForeground"
					 Color="Green" />
	<SolidColorBrush x:Key="OutlinedTextBoxForegroundPointerOver"
					 Color="Blue" />
	<SolidColorBrush x:Key="OutlinedTextBoxForegroundFocused"
					 Color="Indigo" />
	<SolidColorBrush x:Key="OutlinedTextBoxForegroundDisabled"
					 Color="Pink" />

	<SolidColorBrush x:Key="OutlinedTextBoxPlaceholderForeground"
					 Color="Red" />
	<SolidColorBrush x:Key="OutlinedTextBoxPlaceholderForegroundPointerOver"
					 Color="Orange" />
	<SolidColorBrush x:Key="OutlinedTextBoxPlaceholderForegroundFocused"
					 Color="Yellow" />
	<SolidColorBrush x:Key="OutlinedTextBoxPlaceholderForegroundDisabled"
					 Color="Green" />
	<!--#endregion-->
</Page.Resources>

PR Checklist

Internal Issue (If applicable):

#988

@nguyeenvy nguyeenvy requested a review from kazo0 May 26, 2023 20:45
@CLAassistant
Copy link

CLAassistant commented May 26, 2023

CLA assistant check
All committers have signed the CLA.

@nguyeenvy nguyeenvy changed the title Add the Lightweight Styling Text Box Style feat(textbox): Add the Lightweight Styling Text Box Style May 26, 2023
@github-actions
Copy link

github-actions bot commented May 26, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy changed the title feat(textbox): Add the Lightweight Styling Text Box Style refactor(textbox): Add the Lightweight Styling Text Box Style May 29, 2023
@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TextBox-Style branch from 80a24af to 8962668 Compare May 29, 2023 17:15
@github-actions
Copy link

github-actions bot commented May 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented May 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented May 30, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TextBox-Style branch from 4c8439f to fee7b1c Compare May 30, 2023 20:51
@github-actions
Copy link

github-actions bot commented May 30, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented May 30, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-TextBox-Style branch from db7e78d to 50de5e1 Compare June 1, 2023 15:41
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1002.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy self-assigned this Jun 5, 2023
@kazo0 kazo0 merged commit 618fc2e into master Jun 7, 2023
@kazo0 kazo0 deleted the dev/vyng/Lightweight-Styling-TextBox-Style branch June 7, 2023 18:08
@Xiaoy312 Xiaoy312 mentioned this pull request Jun 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material] Lightweight Styling - TextBox Styles
4 participants