Add support for signons.txt format #36
Conversation
|
My primary target was signons3.txt but I also implemented the other versions since they are not much different. |
| file_id = '#2' + chr(ord('b') + self._version) | ||
| assert lines[0] == file_id | ||
|
|
||
| record_size = 3 + self._version |
There was a problem hiding this comment.
Can you add a comment here detailing that with a new version of signons.txt one additional line with data was added to every record.
Also please add comments with links to http://kb.mozillazine.org/Signons.txt http://kb.mozillazine.org/Signons2.txt and http://kb.mozillazine.org/Signons3.txt for future reference.
| @@ -382,6 +413,9 @@ def load_libnss(self): | |||
| # If this succeeds libnss was loaded | |||
| self.NSS = self.find_nss(locations, nssname) | |||
|
|
|||
| if os.name == 'nt' and not (hasattr(self.NSS, "PR_ErrorToName") and hasattr(self.NSS, "PR_ErrorToString")): | |||
There was a problem hiding this comment.
Is NSPR only needed on Windows. Do we need workarounds on other platforms too?
| engines = [ | ||
| (JsonCredentials, {}), | ||
| (SqliteCredentials, {}), | ||
| (TextCredentials, {'version': 1}), |
There was a problem hiding this comment.
The order goes from newer to older (JSON is Firefox 32+), minor thing but should we try version 3 before 1 and 2?
unode
force-pushed
the
master
branch
3 times, most recently
from
f15c99d to
6a0c69b
Compare
|
As Firefox 3 is almost 10 years old I'm closing this as it adds unnecessary dependencies and workarounds. |
No description provided.