Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix svg check for vite 5 #3252

Merged
merged 1 commit into from
Oct 21, 2023
Merged

test: fix svg check for vite 5 #3252

merged 1 commit into from
Oct 21, 2023

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Oct 20, 2023

There's a test at

const svgs = await fg('dist/assets/uno-*.svg', { cwd: root, absolute: true })
expect(svgs).toHaveLength(1)
that expects an SVG asset to be emitted. However in Vite 5, SVG assets are also inline-able so this would be inside the CSS file instead.

I updated the Vite config to fix this for now.

@bluwy bluwy requested a review from antfu as a code owner October 20, 2023 11:59
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7034b8d
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/65326ba26391620008821025
😎 Deploy Preview https://deploy-preview-3252--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu merged commit 5d0a295 into unocss:main Oct 21, 2023
@bluwy bluwy deleted the fix-vite-5-test branch October 22, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants