Skip to content

Commit

Permalink
Remove a needless mutex
Browse files Browse the repository at this point in the history
  • Loading branch information
Witiko committed Oct 31, 2024
1 parent 5b1eaf0 commit cc5d209
Showing 1 changed file with 10 additions and 13 deletions.
23 changes: 10 additions & 13 deletions src/unoserver/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ def __init__(
self.xmlrcp_server = None
self.intentional_exit = False

if self.stop_after is not None:
self.thread_lock = threading.Lock()
self.number_of_requests = 0

def start(self, executable="libreoffice"):
logger.info(f"Starting unoserver {__version__}.")

Expand Down Expand Up @@ -144,18 +140,19 @@ def serve(self):
self.xmlrcp_server = server
server.register_introspection_functions()

self.number_of_requests = 0

def stop_after():
if self.stop_after is None:
return
with self.thread_lock:
self.number_of_requests += 1
if self.number_of_requests == self.stop_after:
logger.info(
"Processed %d requests, exiting.",
self.stop_after,
)
self.intentional_exit = True
self.libreoffice_process.terminate()
self.number_of_requests += 1
if self.number_of_requests == self.stop_after:
logger.info(
"Processed %d requests, exiting.",
self.stop_after,
)
self.intentional_exit = True
self.libreoffice_process.terminate()

@server.register_function
def info():
Expand Down

0 comments on commit cc5d209

Please sign in to comment.