Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tls): import Socket and Server from node:net #405

Merged
merged 1 commit into from
Jan 30, 2025
Merged

refactor(tls): import Socket and Server from node:net #405

merged 1 commit into from
Jan 30, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 30, 2025

No description provided.

@vicb vicb requested review from a team and pi0 as code owners January 30, 2025 05:57
@vicb vicb requested a review from anonrig January 30, 2025 05:57
@pi0
Copy link
Member

pi0 commented Jan 30, 2025

Please revert the tests only relative path change.

@vicb
Copy link
Contributor Author

vicb commented Jan 30, 2025

I reverted the changes in tests, PTAL 🙏

@pi0 pi0 merged commit 09ce665 into main Jan 30, 2025
2 checks passed
@vicb
Copy link
Contributor Author

vicb commented Jan 30, 2025

Thanks a lot @pi0

@pi0 pi0 deleted the tls branch January 30, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @pi0