feat: updates for node v22.9 compatibility #350
Merged
+76
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
commented
Nov 23, 2024
| @@ -16,7 +16,10 @@ export { | |||
| _resolveFilename, | |||
| _resolveLookupPaths, | |||
| builtinModules, | |||
| constants, | |||
There was a problem hiding this comment.
@anonrig I think you have plan to enable compile cache, those methods are not implemented in workerd yet, right?
enableCompileCache, getCompileCacheDir, and related constants
There was a problem hiding this comment.
It is enabled right now. And yes these methods are not implemented.
anonrig
approved these changes
Nov 23, 2024
pi0
changed the title
pi0
changed the title
pi0
reviewed
Nov 26, 2024
pi0
reviewed
Nov 26, 2024
Co-authored-by: Pooya Parsa <[email protected]>
Co-authored-by: Pooya Parsa <[email protected]>
|
Thanks for the reviews and feedback. |
pi0
changed the title
|
Thank you @pi0 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #349, I updated the node types upstream in DefinitelyTyped/DefinitelyTyped#71216 - this was released as
@types/nodev22.9.3The cast is module is no longer needed.