Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withFragment utility #193

Merged
merged 11 commits into from
Feb 5, 2024
Merged

feat: add withFragment utility #193

merged 11 commits into from
Feb 5, 2024

Conversation

IgnisDa
Copy link
Contributor

@IgnisDa IgnisDa commented Nov 21, 2023

Fixes #190.

@pi0 pi0 changed the title add a withHash function feat: add withFragment utility Nov 21, 2023
@IgnisDa
Copy link
Contributor Author

IgnisDa commented Nov 21, 2023

@pi0 should I rename the function to withFragment?

@pi0
Copy link
Member

pi0 commented Nov 21, 2023

I am thinking about it. hash can be confusing with hashing functions specially when we globally auto import ufo utils and fragment is the more technical naming for it. Where as i saw URL class has hash property.

But i think it is safer to go with withFragment 👍🏼

@IgnisDa
Copy link
Contributor Author

IgnisDa commented Nov 21, 2023

@pi0 made the changes

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c1d90e) 95.27% compared to head (16acb71) 95.34%.
Report is 14 commits behind head on main.

❗ Current head 16acb71 differs from pull request most recent head 7dbe05c. Consider uploading reports for the commit 7dbe05c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   95.27%   95.34%   +0.06%     
==========================================
  Files           7        7              
  Lines         867      880      +13     
  Branches      187      190       +3     
==========================================
+ Hits          826      839      +13     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgnisDa

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

@IgnisDa

This comment was marked as off-topic.

@danielroe danielroe requested a review from pi0 January 16, 2024 09:43
src/utils.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit c39b9e9 into unjs:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a withHash function
2 participants