Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parseURL): parse protocol case-insensitively #188

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#180
nuxt/nuxt#24288

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This applies fix on case sensitivity to parseURL

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 November 15, 2023 11:48
@danielroe danielroe self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (92b63c2) 95.11% compared to head (c6ebedc) 95.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files           7        7           
  Lines         840      840           
  Branches      180      180           
=======================================
  Hits          799      799           
  Misses         41       41           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

src/parse.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix: parse special protocols case-insensitively fix(parseURL): parse protocol case-insensitively Nov 15, 2023
@pi0 pi0 merged commit 768210a into main Nov 15, 2023
4 checks passed
@pi0 pi0 deleted the fix/case-insensitive-proto branch November 15, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants