-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue)!: refactor vue loader with vue/compiler-sfc #251
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 82.86% 81.04% -1.82%
==========================================
Files 12 12
Lines 852 881 +29
Branches 133 189 +56
==========================================
+ Hits 706 714 +8
- Misses 144 165 +21
Partials 2 2 ☔ View full report in Codecov by Sentry. |
now fixed |
@Teages This is a nice workaround! Since the PR hasn't received reviews for 1 month, can you temporarily release this fork to NPM? |
@typed-sigterm the package is avalibale on {
"devDependencies": {
"mkdist": "npm:@teages/[email protected]"
}
} or: {
"resolutions": {
"mkdist": "npm:@teages/[email protected]",
}
} It works with the main branch of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the long delay in reviewing, but having tested this with the nuxt/module-builder, I think it's a very nice change.
there are some improvements we might need to make but as long as this results in a major bump, we should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you ❤️
export default _default;
declare module 'vue' {
interface GlobalComponents {
}
interface GlobalDirectives {
}
}
// and many lines... @danielroe Are these global type export expected? I have removed them in 31e93f0 If the next major release isn't coming soon, I think I should cherry-pick this commit to another pull request. |
@Teages I added those so we can track the changes in this pr. I didn't see an issue with your changes... |
Refactor the vue loader with vue/compiler-sfc.
Resolve #209 #249 #243 #14 #15
Close #210
Some break changes:
<script setup lang="*">
, but they are still human readableBut I think it is worth.
also updated test.
It is a draft pull request because I found some timesvue-tsc^2.1.0
will add the vue global declare in dts output for no resaon.It happens in my own package Teages/mkdist-vue-loader but after I merged back to mkdist it disappeared....fixed with 31e93f0
tested with 2452db9