Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fixed cleanDist with addition of --no-clean option #217

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

metaory
Copy link
Contributor

@metaory metaory commented Apr 25, 2024

πŸ”— Linked issue

resolves #216 The option cleanDist was never added to args of citty

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

❌ every build is cleaning the dist/

I'm aware the cleanDist option was added on:
f613c17 support cleanDist option was added by @pi0 long time ago

⚠️ but no cli arg was ever added

This PR Resolves #216
It add a new optional cli arg --no-clean when provided the make function wont clean the dist path
Default behavior continues as before, with clean being true

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 276c393 into unjs:main Dec 13, 2024
2 checks passed
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (9000888) to head (3b12e6a).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
src/cli.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   82.86%   80.49%   -2.37%     
==========================================
  Files          12       12              
  Lines         852      887      +35     
  Branches      133      189      +56     
==========================================
+ Hits          706      714       +8     
- Misses        144      171      +27     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The option cleanDist was never added to args of citty
2 participants