feat: migrate from unenv v1 to node-mock-http
#970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from
unenv(for Workers support) tonode-mock-httpwhich is extracted from codebase of unenv v1.The reason for migration is that unenv v2 will have breaking changes for
node:http(unjs/unenv#364) and ecosystem migration is not easy.One temporarily downside is that this causes duplicate polyfills for Nitro users however nitro (v2) will also migrate.
One benefit of this new extracted package is that we can avoid polyfills for
node:bufferandnode:eventsin Node.js runtimes (using export conditions innode-mock-http)