Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ; in app.use(router;) example createRouter() #732

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

devseckobz
Copy link
Contributor

@devseckobz devseckobz commented Apr 16, 2024

const app = createApp();
const router = createRouter();
app.use(router;)

to

const app = createApp();
const router = createRouter();
app.use(router)

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

const app = createApp();
const router = createRouter();
app.use(router;)

to 

const app = createApp();
const router = createRouter();
app.use(router)
Copy link
Member

@nozomuikuta nozomuikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the fix!

@nozomuikuta nozomuikuta merged commit f757d80 into unjs:main Apr 16, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants