Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix session example #702

Merged
merged 1 commit into from
Apr 17, 2024
Merged

docs: fix session example #702

merged 1 commit into from
Apr 17, 2024

Conversation

MathieuDerelle
Copy link
Contributor

@MathieuDerelle MathieuDerelle commented Mar 13, 2024

πŸ”— Linked issue

none

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

session config cookie is of type CookieSerializeOptions :
https://github.com/unjs/cookie-es/blob/a3495860248b98e7015c9a3ade8c6c47ad3403df/src/types.ts#L14

which does not include name

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(session config example): wrong place for session name docs: fix session example Apr 17, 2024
@pi0 pi0 merged commit e8be314 into unjs:main Apr 17, 2024
@pi0
Copy link
Member

pi0 commented Apr 17, 2024

Thanks!

@MathieuDerelle MathieuDerelle deleted the patch-1 branch September 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants