Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readRawBody): read chunked body #652

Merged
merged 11 commits into from
Jun 18, 2024
Merged

fix(readRawBody): read chunked body #652

merged 11 commits into from
Jun 18, 2024

Conversation

aaharu
Copy link
Member

@aaharu aaharu commented Feb 17, 2024

πŸ”— Linked issue

resolve #651

And SuperTest can not successfully test the request with chunked body, so I rewrote the body test using undici.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@aaharu aaharu marked this pull request as ready for review March 10, 2024 09:19
@aaharu
Copy link
Member Author

aaharu commented Apr 24, 2024

I think this is a bug in h3.
I am not having trouble with this issue, but I think it should be fixed.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 79.43%. Comparing base (a58d7c9) to head (077ec8c).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   77.83%   79.43%   +1.59%     
==========================================
  Files          47       54       +7     
  Lines        4286     5334    +1048     
  Branches      611      678      +67     
==========================================
+ Hits         3336     4237     +901     
- Misses        933     1078     +145     
- Partials       17       19       +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 changed the title fix: read chunked body fix(readRawBody): read chunked body Jun 18, 2024
@pi0 pi0 merged commit 7c97d57 into unjs:main Jun 18, 2024
5 checks passed
@aaharu aaharu deleted the chunked-request branch June 19, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H3 - stripping body from request when received with transfer-encoding:chunked
2 participants