-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(getSession): use semaphore lock for unseal operation #612
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 77.69% 77.79% +0.09%
==========================================
Files 47 47
Lines 4269 4279 +10
Branches 604 609 +5
==========================================
+ Hits 3317 3329 +12
+ Misses 935 933 -2
Partials 17 17 β View full report in Codecov by Sentry. |
Thanks for the PR β€οΈ I have added tests and few refactors to simplify using same As a future enhancement, we need to do concurrency/promise-reuse in function level which is currently not possible as |
π Linked issue
#610
β Type of change
π Description
I've added session locking that will asynchronously block consecutive
getSession
attempts when unsealing.This should solve the problem where consecutive
getSession
calls break session data and prevent duplicate unseals (I tested the changes against the issue's reproduction).Resolves #610
π Checklist