Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support auto complete for http header names #542

Merged
merged 8 commits into from
Oct 3, 2023

Conversation

GalacticHypernova
Copy link
Contributor

@GalacticHypernova GalacticHypernova commented Sep 20, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

NOTE: I marked it as a new feature as technically there wasn't any autocompletion beforehand. If I should change this to enhancement please do let me know and I apologize in advance.

πŸ“š Description

This PR adds HTTP header autocompletion for better DX. Tested on my local machine, this makes writing headers more convenient for many header manipulation operations.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #542 (2afa8d8) into main (9e81e4e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   83.74%   83.83%   +0.08%     
==========================================
  Files          31       31              
  Lines        3544     3563      +19     
  Branches      543      540       -3     
==========================================
+ Hits         2968     2987      +19     
  Misses        576      576              
Files Coverage Ξ”
src/types.ts 100.00% <100.00%> (ΓΈ)
src/utils/request.ts 92.89% <100.00%> (+0.18%) ⬆️
src/utils/response.ts 78.90% <100.00%> (+0.23%) ⬆️

@pi0 pi0 changed the title feat: In-IDE HTTP header autocompletion feat: support auto complete for http header names Oct 3, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition thanks!

@pi0 pi0 merged commit fb79f41 into unjs:main Oct 3, 2023
6 checks passed
@GalacticHypernova
Copy link
Contributor Author

GalacticHypernova commented Oct 3, 2023

Always glad to help!
And thanks for teaching me to put such things in src/types, will remember to do so in future PR's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants